Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug with END positions for deletions in MAF output. #5876

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

jonn-smith
Copy link
Collaborator

Before the end positions could be too large for some deletions in MAF output mode.
Now the end positions are correct for all deletions in MAF output mode.

Fixes #5875

Before the end positions could be too large for some deletions.
Now the end positions are correct for all deletions.

Fixes #5875
@codecov-io
Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #5876 into master will decrease coverage by 0.006%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #5876       +/-   ##
===============================================
- Coverage     86.833%   86.827%   -0.006%     
+ Complexity     32275     32274        -1     
===============================================
  Files           1987      1987               
  Lines         149022    149026        +4     
  Branches       16472     16472               
===============================================
- Hits          129400    129395        -5     
- Misses         13609     13620       +11     
+ Partials        6013      6011        -2
Impacted Files Coverage Δ Complexity Δ
.../tools/funcotator/mafOutput/MafOutputRenderer.java 93.973% <100%> (ø) 80 <0> (ø) ⬇️
...uncotator/mafOutput/MafOutputRendererUnitTest.java 97.531% <100%> (+0.031%) 27 <0> (ø) ⬇️
...er/tools/funcotator/FuncotatorIntegrationTest.java 84.052% <0%> (-1.868%) 114% <0%> (-3%)
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 60% <0%> (ø) 2% <0%> (ø) ⬇️
...nder/utils/runtime/StreamingProcessController.java 67.773% <0%> (+0.474%) 33% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 80% <0%> (+30%) 3% <0%> (+2%) ⬆️

Copy link
Collaborator

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- merge when ready @jonn-smith

@droazen droazen assigned jonn-smith and unassigned droazen Apr 11, 2019
@jonn-smith jonn-smith merged commit 8278fef into master Apr 11, 2019
@jonn-smith jonn-smith deleted the jts_MAF_deletion_end_pos_fix_5875 branch April 11, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants